question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[DataTableSkeleton] Add prop to hide header in table skeleton

See original GitHub issue

Summary

After #5752 was merged, the DataTableSkeleton component always has a header now, which is a change from how it used to look previously (which is understandable, given the v10 bump).

For the React component, it would be nice to have a prop such as showHeader that can show or hide the extra divs, instead of having to apply some sort of CSS to hide them.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
richardpilotcommented, May 8, 2020

There are also use cases where you want the DataTable to be a skeleton but you have actions available in the toolbar that do not need a skeleton. For example, the primary button of a table being create new object, which can still occur whilst the underlying data is being refresh (causing a skeleton) e.g.

image

2reactions
asudohcommented, May 4, 2020

@nictownsend My apologies for the change in table skeleton yielded a minor breaking change; The change was meant to be part of v10 but the team slipped it through the crack, and it was seen not worth waiting for v11. A possible future consideration for this area is better release noting.

Wrt providing an option to hide title/description portion, technically it makes sense, but let’s see what @carbon-design-system/design thinks from the point of whether our design guide since v10 allows it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Adding skeleton effect to a table with sorting/pagination
Show activity on this post. I want to add Skeleton effect to a MUI table. The only requirement for the table is sorting...
Read more >
DataTable - Carbon Components Svelte - Render
Set sortable to true to enable table column sorting. To disable sorting on a specific column, set sort to false in the header...
Read more >
Angular PrimeNG Skeleton DataTable - GeeksforGeeks
Example 1: This is a basic example illustrating how to show a skeleton data table with 2 columns and 3 rows. app.component.html. app.component....
Read more >
Data table – Carbon Design System
The data table component allows for the flexible display and sorting of information.
Read more >
Improve UX With the Skeleton Component in React and ...
The skeleton component also has an animation prop. ... The table header includes columns for Name, Username, Email, and Phone.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found