ExpandableTile tileMaxHeight property is overwritten.
See original GitHub issueDetailed description
Describe in detail the issue you’re having.
tileMaxHeigh
property that is passed to ExpandableTile components gets overwritten by other values after clicking on the Tile.
Is this issue related to a specific component?
ExpandableTile
What did you expect to happen? What happened instead? What would you like to see changed?
I’m not entirely sure as the purpose of tileMaxHeight prop is not very clear but I would expect somewhat respecting this passed height by either TileAboveTheFoldContent or TileBelowTheFoldContent or both.
What browser are you working in?
Chrome
What version of the Carbon Design System are you using?
6.33.4
Steps to reproduce the issue
- Use official storybook
- Go to the Tile/Expendable
- Change the tileMaxHeight knob
- After clicking on the tile twice maxHeight gets reset.
Please create a reduced test case in code sandbox
https://codesandbox.io/s/n7891xom4 < = What’s interesting here is that I was not able to reproduce It anywhere else than storybook, using codesandbox tileMaxHeight property has no effect on the component at all (which is also not that good).
Additional information
I would love to make a PR for this as a Tile component seems very useful but I need more clarification of what is the exact purpose of the tileMaxHeight prop.
Issue Analytics
- State:
- Created 5 years ago
- Comments:8 (6 by maintainers)
Top GitHub Comments
Not sure if what @lekterable said matches my proposal, but will keep it in mind. May need stateful/stateless separation tacked in #2207.
Hi there! 👋 If you’re wondering why this issue was moved, we’re currently updating our repo structure so that every package is found in the same project.
This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: carbon@us.ibm.com. Thanks!