question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Filterable Multiselect focus outline on wrong node

See original GitHub issue

When a filterable multiselect has some options selected, clicking on it’s <input> puts focus outline on wrong node:

Screen Shot 2021-01-12 at 22 05 18

Environment

Operating system

MacOS

Browser

Chrome

Detailed description

What version of the Carbon Design System are you using?

10.26

What did you expect to happen?

Focus outline around whole control.

What happened instead?

Focus outline around <input>

Test case

See https://react.carbondesignsystem.com/?path=/story/multiselect--filterable or https://react.carbondesignsystem.com/?path=/story/multiselect--filterable

Note that clicking more to the left will put the focus outline around the whole control:

Screen Shot 2021-01-12 at 22 19 22

Presumably a regression from #4721.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
wkeesecommented, Jan 22, 2021

I agree you can debate which focus outline is better from an accessibility standpoint, but I think you need to pick one way or the other. Right now tabbing into or clicking on the <input> puts the focus outline on the <input>:

Screen Shot 2021-01-22 at 8 13 37

But clicking on the upper left (when options are selected) puts the focus outline on the whole control:

Screen Shot 2021-01-22 at 8 09 20

The other (very related) issue is that there’s actually an extra tab stop on the whole control: clicking on the upper left and then pressing the tab key goes to the (2 x) button, and then another tab goes to the <input>… i.e. there are 3 tab stops where there should be 2.

(Both these screenshots are from React on Chrome/mac but I assume it’s a universal behavior.)

PPS: I would also question the slightly different background colors for the left side vs. the input.

0reactions
wkeesecommented, Jul 26, 2021

Looks like you fixed this. Judging from https://react.carbondesignsystem.com/?path=/story/components-multiselect--filterable the focus outline is always around the whole control (except when the (2x) button is focused, in which case the focus outline is just on that button).

Read more comments on GitHub >

github_iconTop Results From Across the Web

Focus Filterfield of ng-multiselect-dropdown automatically ...
Everything works fine, but I want to focus the filter input field automatically when I open the multiselect dropdown. Here is my html...
Read more >
Vue-Multiselect | Vue Select Library
focus () – You can dispatch a focus event on the multiselects $el or on the search input directly. Toggle Open Close Multiselect...
Read more >
Bootstrap Multiselect Examples - CodeHim
Selects all options. If justVisible is set to true or not provided, all visible options are selected (when using the filter), otherweise (...
Read more >
Filtering Angular Material NestedTreeControl Nodes
To achieve both the above ends, we will refactor the Nested Multi-select Tree Demo from the aforementioned article by adding a Show Selected ......
Read more >
Vue 3 Multiselect - @vueform/multiselect - npm
Start using @vueform/multiselect in your project by running `npm i ... inset-0 outline-none focus:ring-0 appearance-none box-border border-0 ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found