question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix bug with setting theme in compatability mode resulting in a noop

See original GitHub issue

This issue was originally reported by @janhassel where the compat theme was not able to have its value changed.

Code to reproduce:

@use '@carbon/react/scss/reset';
@use '@carbon/react/scss/compat/themes';
@use '@carbon/react/scss/compat/theme' with (
  $theme: themes.$g90
);

body {
  background: theme.$background;
  color: theme.$text-primary;
}

Here, we expected the tokens to use values from the g90 theme but they use the value from the white theme instead. It seems like this is related to the issue Jan reported in that the theme would not allow you to correctly retrieve interactive-01 as a token because the themes were not being merged

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
joshblackcommented, Oct 15, 2021

@janhassel I think until we update the code to use the new tokens we’ll run into this issue since the theme is looking for tokens that don’t exist. I’ll make sure we will go and update them in the next release though so that you can configure the theme as expected 👍

1reaction
joshblackcommented, Sep 8, 2021

@janhassel thanks!

Side-note: I think you’ll have to always use the second form just as a heads up otherwise you’ll get the error where a module has been used before it’s being configured.

Read more comments on GitHub >

github_iconTop Results From Across the Web

themes are not disabled in compatibility mode
The program that you are running is incompatible with Aero themes. When this happens, some visual elements are automatically turned off. In this ......
Read more >
bbPress 2.3.2 Bug Fix Release
3 Theme Compatibility tweaks for improved integration with existing ... Fixes issues causing some widget settings not to save correctly.
Read more >
Warehouse theme changelog - Shopify Themes - Maestrooo
This page keeps track of all changes that happened in the theme so far. Please note that, per our update policy, we can...
Read more >
General: Venue theme release notes - Safe As Milk Help Center
Fixed flashing underscore on product form bug. Product sale price was re-connected to colour settings. Slideshow section hidden content bug ...
Read more >
Jupiter Release Notes - WordPress Websites For Businesses ...
Jupiter theme, Jupiter Donut plugin, WPBakery Page Builder (Modified ... Bug Fix: Fixed confusing Comments option descripiton in Jupiter Page Options.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found