Fix bug with setting theme in compatability mode resulting in a noop
See original GitHub issueThis issue was originally reported by @janhassel where the compat theme was not able to have its value changed.
Code to reproduce:
@use '@carbon/react/scss/reset';
@use '@carbon/react/scss/compat/themes';
@use '@carbon/react/scss/compat/theme' with (
$theme: themes.$g90
);
body {
background: theme.$background;
color: theme.$text-primary;
}
Here, we expected the tokens to use values from the g90 theme but they use the value from the white theme instead. It seems like this is related to the issue Jan reported in that the theme would not allow you to correctly retrieve interactive-01
as a token because the themes were not being merged
Issue Analytics
- State:
- Created 2 years ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
themes are not disabled in compatibility mode
The program that you are running is incompatible with Aero themes. When this happens, some visual elements are automatically turned off. In this ......
Read more >bbPress 2.3.2 Bug Fix Release
3 Theme Compatibility tweaks for improved integration with existing ... Fixes issues causing some widget settings not to save correctly.
Read more >Warehouse theme changelog - Shopify Themes - Maestrooo
This page keeps track of all changes that happened in the theme so far. Please note that, per our update policy, we can...
Read more >General: Venue theme release notes - Safe As Milk Help Center
Fixed flashing underscore on product form bug. Product sale price was re-connected to colour settings. Slideshow section hidden content bug ...
Read more >Jupiter Release Notes - WordPress Websites For Businesses ...
Jupiter theme, Jupiter Donut plugin, WPBakery Page Builder (Modified ... Bug Fix: Fixed confusing Comments option descripiton in Jupiter Page Options.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@janhassel I think until we update the code to use the new tokens we’ll run into this issue since the theme is looking for tokens that don’t exist. I’ll make sure we will go and update them in the next release though so that you can configure the theme as expected 👍
@janhassel thanks!
Side-note: I think you’ll have to always use the second form just as a heads up otherwise you’ll get the error where a module has been used before it’s being configured.