question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Floating Menu] Focus wrap should work without having to put in extra elements

See original GitHub issue

@asudoh @dakahn @snidersd

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you’re having.

Demos are deceiving because there is a visually hidden input that is not part of the “demo” code but this input is required in order to have the a11y focus wrap feature work. I understand that any “focusable” element following a floating menu would work and it does not have to be this specific input but we should not assume that of our users’ use-cases. Focus wrap should work without having to add in extra elements, especially if it’s something like this input which is visually hidden but is visible to screen reader users, making it really confusing as to why they are reaching a text input.

Is this issue related to a specific component?

Any component that uses Floating Menu

What did you expect to happen? What happened instead? What would you like to see changed?

Focus wrap should work with the code provided on the website’s demo code. The focus wrap does not work if you copy and paste the code in to another system and even the Carbon code pen demo does not work as expected.

What browser are you working in?

Chrome, Safari, Firefox

What version of the Carbon Design System are you using?

v10.4.1

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Watson Health Design Pattern & Asset Library; Release date coming up is end of Q3

Steps to reproduce the issue

  1. Open the overflow menu and navigate to the last item in the list
  2. press Tab
  3. focus is moved outside of the menu and menu remains open

Please create a reduced test case in CodeSandbox

Doesn’t work as expected https://codepen.io/team/carbon/pen/PgNGop

Works once I add in extra incorrect element https://codepen.io/elizabethsjudd/pen/mNmZdR

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
asudohcommented, Aug 2, 2019

I did, but I’d say, don’t wait for assignment - Carbon is open source!

1reaction
elizabethsjuddcommented, Aug 1, 2019

I can definitely make the change to the hbs templates. Unfortunately, I don’t have time allocated to work on the react codebase at this time. We are trying to release our carbon 10 version of WH PAL and are blocked by these a11y updates to Carbon. My team has allowed me to work on the Carbon Vanilla work since this is blocking us from helping our users and moving forward with our projects especially since the Carbon core team has deprioritized most Carbon Vanilla work for the time being.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Mastering wrapping of flex items - CSS: Cascading Style Sheets
There is however the ability to wrap flex items onto new lines, ... In this guide I will explain how this works, what...
Read more >
CodeMirror 5 User Manual
User manual and reference guide version 5.65.11. CodeMirror is a code-editor component that can be embedded in Web pages. The core library provides...
Read more >
Stop floating divs from wrapping - html - Stack Overflow
There is no way to do this with CSS level 1 that I'm aware of and I refused to think I'd have to...
Read more >
Material Bottom Tabs Navigator
This API also requires that you install react-native-vector-icons ! If you are using Expo managed workflow, it will work without any extra steps....
Read more >
tkinter.ttk — Tk themed widgets — Python 3.11.1 documentation
The main difference is that widget options such as “fg”, “bg” and others related to widget styling are no longer present in Ttk...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found