question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Card group with static]: Update Storybook preview to include "Add CTA Link" boolean

See original GitHub issue

Engineering info:


Description

  • While ensembling an example of the Card Group component using Card with static variant, I noticed that the <dds-text-cta> component that’s being used is not aligned to the bottom of the card.
  • This might be due to the fact that <dds-text-cta> might not be accounted for in the same height function that’s defined in the Card group component.
  • <dds-text-cta> is used in place of <dds-card-cta-footer> because the static card variant doesn’t enable the whole card to be clickable, except for the CTA link.

Screen Shot 2022-05-03 at 10 34 26 AM

Component(s) impacted

Card Group

Browser

Chrome, Safari, Firefox, Microsoft Edge

Carbon for IBM.com version

v.1.33

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

AEM

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://codesandbox.io/s/sharp-hugle-ylz0gg?file=/index.html

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
proeungcommented, May 3, 2022
1reaction
oliviaflorycommented, May 12, 2022

Hi @proeung, thank you for the reminder.

I lean towards having the CTAs hidden by default due to the original intention of static cards being…static. The CTA was added after if I remember correctly. So if it’s ok with you I’d love to have the boolean option with “Add CTA”.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Controls - Storybook - JS.ORG
To use the Controls addon, you need to write your stories using args. ... It works well with certain types of args, such...
Read more >
Next-level component showcasing with Storybook controls
Learn about controls, a new Storybook addon that lets you dynamically interact with your React components for demo and testing purposes.
Read more >
NetSuite Applications Suite - Working with Groups
Multi–Book Accounting and Adjustment-Only Book Support in Tax Reporting Framework ... FEFO Lot Assignments and the Static Route Management SuiteApp.
Read more >
How can I use CSS framework styles inside a storybook #25
I added a preview-head.html per these docs, linking up my stylesheet like so: <link rel="stylesheet" href="./static/style.css" />.
Read more >
Create pages on the fly with Dynamic Zone - Strapi
On the Page collection-type, click on Add a component for your ... I advise you to include the header, buttons and link components...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found