question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Masthead] Web components storybook demo clean up

See original GitHub issue

Detailed description

Describe in detail the issue you’re having.

Masthead storybook clean up, React issue #6409

Default

Knobs:

  • no platform knob, default global nav should not enable a platform name

Storybook example is good as-is, update knobs per above masthead-global

~With custom navigation~ hide/remove story

  • We are proposing to hide this story, in most cases, IA guild does not recommend teams have custom navigation within the L0. But we do not want to deprecate yet as it would be a breaking change.
  • ~no platform knob, default global nav should not enable a platform name~
  • ~Label should be sentence case: With custom navigation (not initial caps)~
  • ~Custom navigation should not have mega menu styling, remove all mega menu styling and use dropdown. May have to change data sets?~

Screen Shot 2021-06-17 at 3 50 31 PM Screen Shot 2021-06-17 at 3 51 02 PM

Search Open Onload

  • label should be in sentence case, not initial caps Search open onload
  • hide platform knob

Storybook demo proposal: masthead-Search-open-onload

With Platform

  • label should be in sentence case, not initial caps With platform
  • ~All nav items within the With platform story should not have mega menu styling, remove all mega menu styling and use dropdown. May have to swap data sets?~
  • Remove all links from With platform story other than the Platform
  • Update “Cloud” to “Platform” Screen Shot 2021-06-17 at 4 01 35 PM

Story book demo proposal: masthead-with-platform

With L1

  • update L1 nav content to the example shown in the image below, red italic indicates dropdown items. Reference Analytics page for content. Note: ignore “Services” dropdown on the live page.

Storybook demo proposal: masthead-with-L1

With Alternate Logo And Tool Tip

  • Label should be sentence case: With alternate logo and tool tip (not initial caps)

Storybook demo good as-is

Is this a feature request (new component, new icon), a bug, or a general issue?

storybook clean up

Is this issue related to a specific component?

Masthead demo & variants

What did you expect to happen? What happened instead? What would you like to see changed?

What browser are you working in?

Chrome

What version of Carbon for IBM.com are you using?

WC

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Additional information

Reasoning for not using mega menu in anything other than Default global nav: the IA team has not come to a conclusion on whether teams can customize their own mega menus. We should not show mixing customized labels with the global nav labels & data or show the global nav with a platform.

Cloud is the only other team that has a customized nav & mega menu approval.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
oliviaflorycommented, Jul 6, 2021

Content updates added to the task description above, reviewed and approved by @shixiedesign.

@RobertaJHahn this is ready for scheduling

1reaction
oliviaflorycommented, Jul 1, 2021

@shixiedesign I updated the tasks above and included the images of the storybook demo for masthead that we reviewed in Design review today so you can take another look.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Cleaning up (undefining) custom elements? #754 - GitHub
A long running, wanting-to-be-robust, web application might like to unload elements if it knows they are not being used on the page any...
Read more >
Demoing: Storybook - Open Web Components
Open Web Components provides a set of defaults, recommendations and tools to help facilitate your Web Component.
Read more >
Building a Storybook-like demo browser with web components
I recently tried Storybook, a popular tool for browsing the demos and documentation for a UI component library. I think Storybook offers a ......
Read more >
Introduction to Storybook for Web Components - Piyush's Blog
Storybook is a tool for UI development. It makes development faster and easier by isolating components. This allows you to work on one ......
Read more >
Storybook for web components on steroids
Building an application requires many parts and storybook can help you manage it. Here we explore how to optimize storybook for web ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found