Latest carbon v9 breaks DataTableSkeleton
See original GitHub issueWhat package(s) are you using?
-
carbon-components
-
carbon-components-react
Detailed description
Describe in detail the issue you’re having. After updating to the latest carbon 9.91.2, DataTableSkeleton is not shown. Verified that 9.91.1 does not work also. 9.91.0 works.
Is this issue related to a specific component? DataTableSkeleton
What did you expect to happen? What happened instead? What would you like to see changed? Loading skeleton is shown
What browser are you working in? Chrome Version 74.0.3729.169 (Official Build) (64-bit)
What version of the Carbon Design System are you using? 9.91.2
What offering/product do you work on? Any pressing ship or release dates we should be aware of? IBM cloud
Steps to reproduce the issue
- Step one
- Step two
- Step three
- etc.
This is the code we use
{this.props.loading ? <DataTableSkeleton rowCount={1} /> : <Table .../>}
Please create a reduced test case in CodeSandbox https://codesandbox.io/s/github/IBM/carbon-components/tree/master/examples/codesandbox https://codesandbox.io/s/codesandbox-99gxn
Additional information
- Screenshots or code
- Notes
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:8 (8 by maintainers)
Top GitHub Comments
I see, if you can spot what commit made such change it’ll be great, to ensure we do the right thing to fix the problem. Thanks!
verified fixed in 9.91.3