Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
ModalWrapper: Properly unused prop `handleOpen`?
See original GitHub issueSummary
I’m not sure if I just don’t see the use of the prop handleOpen.
The component uses a class method this.handleOpen, but the prop handleOpen seems not to be used in any way. I don’t even see the prop passed down to a defined prop of the component Modal.
Maybe someone can have a look at this to check my supposition.
If I’m right, I would fix this issue together with a new feature I had in mind, when opening the source code.
Relevant information
Here’s the line of the prop definition: https://github.com/IBM/carbon-components-react/blob/0e2f293fc1731b1a848aae090a5d530e9deac369/src/components/ModalWrapper/ModalWrapper.js#L17
Issue Analytics
- State:
- Created 5 years ago
- Reactions:1
- Comments:7 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@tw15egan Just my thoughts; Probably not. New modal doc in the work that explains how to implement a state manager for modal (instead of using
<ModalWrapper>) would be the ultimate solution.Hi @emyarod thanks for looking at this. I’ll make my changes to the code today. I think I’ll refactor the props of the component and add some descriptions, etc.