question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Pictograms have extra padding

See original GitHub issue

What package(s) are you using?

  • carbon-pictograms

Detailed description

Describe in detail the issue you’re having.

The pictograms have a much larger padding around them than expected from the specs on the IDL documentation Example of SVG Screen Shot 2020-03-05 at 3 55 42 PM

Expected padding Screen Shot 2020-03-05 at 3 54 04 PM

The extra padding is causing alignment issues between the pictograms and text because the artwork doesn’t span to the edge of the container as it did before. Design intent using 1px border specs Screen Shot 2020-03-05 at 2 48 27 PM

What is happening using svg from pictogram package Screen Shot 2020-03-05 at 2 47 09 PM link to storybook

Is this issue related to a specific component?

All pictogram svg files

What did you expect to happen? What happened instead? What would you like to see changed?

Is the extra padding around the pictograms an intended, permanent change to the pictogram svgs that designers need to account for?

I would have thought the pictograms would adhere to the size they were drawn to, accounting for the 1px padding specified on the IDL page Screen Shot 2020-03-05 at 1 35 44 PM

What browser are you working in?

All browsers

What version of the Carbon Design System are you using?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Digital Design System and Web simplification – launching May 2020

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code
  • Notes

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
conradenniscommented, Mar 17, 2020

Russ to set up a meeting between Brand team and Carbon to discuss how to deal with this issue.

1reaction
conradenniscommented, Mar 6, 2020

@laurenmrice thanks for the heads up, the repo is still private and is mostly intended for artwork creation and contribution so it might be worth keeping this one here.

@oliviaflory thanks for calling attention to this issue. The extra padding around the pictogram is intentional and is actually the corresponding container size for the pictograms as in the image shown below.

Screen Shot 2020-03-06 at 4 56 18 PM

While the intent is to include this extra space for container shapes in the SVG file for ease of use, it seems like the inclusion of the container space is causing issues with alignment when a container is not needed. I’m not sure how we might address this issue in code but it’s something I can bring up with the production team on the brand side and it’ll be good to get some perspective from the Carbon folks on how we can avoid this issue moving forward.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Update pictograms from 48x48 to 32x32 · Issue #5693 · carbon ...
When we have our pictogram command, make sure they render at 32x32 without the padding ... Pictograms have extra padding #5550.
Read more >
IBM Design Language – Pictograms
The grid contains 1px padding. This ensures pictograms will retain their desired appearance when exported. Only extend artwork into the padding for additional...
Read more >
The (M)SDS HyperGlossary: Pictograms
Pictograms are pictorial symbols for a word, phrase, object, or concept. ... have the image of a lit cigarette with a red slash...
Read more >
Hazard Pictograms - Graphic Products
OSHA has adopted eight of these. OSHA does not require the use of the environmental pictogram, but this pictogram may be used to...
Read more >
Pictogram Requirements | Avalis Wayfinding Solutions
EXCEPTION: Exterior signs that are not located at the door to the space they serve shall not be required to comply with 703.2....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found