pointing to font @ latest causes errors
See original GitHub issueDetailed description
We use carbon in our application. We keep carbon locked to a specific version so that we can control when we get updates. Part of the testing we do involves visual regression testing (vrt), which can catch the most minor differences a styling change might have. We noticed our vrt tests we being inconsistent, but almost always due to typography. This error is caused by a non-locked version of plex.
in _css–plex-core.scss you create $font-path
with this line:
$font-path: 'https://unpkg.com/carbon-components@latest/src/globals/fonts' !default;
But because you choose to use @latest
, then any application that ingests Carbon is forced to always use the latest version of plex. Recently there was an update to plex, but not an update to carbon, and now a majority of our vrt tests are failing.
Additional information
Solution
Lock your $font-path
to a specific version of plex
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (3 by maintainers)
Top GitHub Comments
I think @asudoh had the idea to warn out in console if the default value is used. That way we don’t break anyone using it, but it can flag improper usage and provide guidance for how to rectify 👍
🎉 This issue has been resolved in version 9.8.3 🎉
The release is available on:
Your semantic-release bot 📦🚀