question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Problem with dark themes' `$ui-02` and '$ui-03` values are the same

See original GitHub issue

Problem:

Dark theme’s $ui-02 and '$ui-03` are the same.

$ui-02

It appears $ui-02 has the same usage and values as $field-02 on all themes. Potentially we can drop $ui-02 if there’s never a use case for it.

$ui-03

$ui-03 are showing up in the following places:

  • Accordion, divider lines
  • Code snippet with numbers, divider line on the left between num and code
  • Tabs, underline for unselected
  • Progress indicator, progress bar
  • Pagination, divider lines
  • Overflow, rule
  • Data table, header bar

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:21 (19 by maintainers)

github_iconTop GitHub Comments

1reaction
laurenmricecommented, Mar 24, 2020

I would be fine with calling this new token decorative-01 until we audit our token naming for v11.

Values per theme:

White G10 G90 G100
G20 #e0e0e0 G20 #e0e0e0 G60 #6f6f6f G70 #525252
1reaction
laurenmricecommented, Mar 9, 2020

Oh right sorry, reread above comments ^ we will need to create a new token to use instead of updating ui-03 token values. We don’t want to update values for ui-03 because then it will affect components negatively across the board that don’t have a light prop.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dark themes: ui-02 and ui-03 have same values. #4647 - GitHub
Need to figure out what values need to be represented for the Dark themes so they don't blend in together when being used...
Read more >
Dark theme - Android Developers
Dark theme applies to both the Android system UI and apps running on the device. ... selecting the Battery Saver mode enables Dark...
Read more >
Next Experience UI Dark Theme, now also on Core UI...
With the Tokyo release, The Dark Theme does apply to Core UI experiences! The same examples as shown before, though now on a...
Read more >
Dark theme - Material Design
A dark theme displays dark surfaces across the majority of a UI. It's designed to be a supplemental mode to a default (or...
Read more >
8 Tips for Dark Theme Design - UX Planet
That means a dark theme just can't communicate the same as the light theme. As a result, dark and light themes will always...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found