Update DataTableSkeleton component to v10
See original GitHub issueWhat package(s) are you using?
-
carbon-components
-
carbon-components-react
Detailed description
I’m using the DataTableSkeleton component as a loading pattern before the data from my DataTable renders. The difference in styles is creating a lot of jumping and repositioning.
Is this issue related to a specific component?
DataTableSkeleton component
What did you expect to happen? What happened instead? What would you like to see changed?
I expected to see the v10 styles on the skeleton component. It still had v9 which caused the header styles and rows to be a bit different, and it didn’t include the table title and description.
What browser are you working in?
Chrome
What version of the Carbon Design System are you using?
v10
What offering/product do you work on? Any pressing ship or release dates we should be aware of?
This was discovered while working on the Developer Essentials tutorial
Steps to reproduce the issue
- Run the 3rd Tutorial step (completed) to see the DataTableSkeleton load in with different styles.
Additional information
Issue Analytics
- State:
- Created 4 years ago
- Comments:9 (7 by maintainers)
Top GitHub Comments
We also need this to be optional. This component seems to have regressed in function, as it is missing the headers, which we were providing so shouldn’t be a skeleton and also add the top header title which we don’t use. We now have to hide it in css or use the old version of this component as our own which is not very future proof.