question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update design tokens with latest values

See original GitHub issue

Before our RC0 release, we need to go through the tokens defined in our themes package and verify that the values match the latest in: https://carbondesignsystem.notion.site/final-List-of-new-tokens-c507394e43fe4daa9f0cd0eedb25d1e4

Checklist

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
aagonzalescommented, Jan 25, 2022

Yeah I know I talked to @joshblack about this and maybe we never opened a ticket for it but anywhere where $field-disabled is used we’re just going back to using $field and same with $layer-disabled (should be replaced with just $layer.

So they’re in use now but they shouldn’t be. Code needs to be updated to replace the disabled tokens.

Update: Here’s the issue https://github.com/carbon-design-system/carbon/issues/9832#issuecomment-984082532

1reaction
aagonzalescommented, Jan 25, 2022

Color token value audit When auditing the tokens today, I’ve noticed a lot of the hover state tokens are still using the old adjustLightness function instead of the new IDL hover tokens. Here is the list that needs to be updated along with other bugs I found. They almost all are related to the hover color so idk what’s up with that.

White theme

  • backgroundInverseHover: Gray-80-hover
  • backgroundSelectedHover: Gray-20-hover
  • layerHover01: Gray-10-hover
  • layerHover02: White-hover
  • layerHover03: Gray-10-hover
  • layerDisabled: remove?
  • layerAccentHover01: Gray-20-hover
  • layerAccentHover02: Gray-20-hover
  • layerAccentHover03: Gray-20-hover
  • fieldHover01: Gray-10-hover
  • fieldHover02: White-hover
  • fieldHover03: Gray-10-hover
  • fieldDisabled: remove?
  • iconDisabled: adjustAlpha(iconPrimary, 0.25);

Gray 10 theme

  • backgroundHover: Gray-10-hover
  • backgroundInverseHover: Gray-80-hover
  • backgroundSelectedHover: Gray-20-hover
  • layerDisabled: remove?
  • layerAccentHover01: Gray-20-hover
  • layerAccentHover02: Gray-20-hover
  • layerAccentHover03: Gray-20-hover
  • fieldDisabled: remove?
  • skeletonBackground: Gray-10-hover
  • iconDisabled: adjustAlpha(iconPrimary, 0.25);

Gray 90 theme

  • backgroundHover: Gray-90-hover
  • backgroundInverseHover: Gray-10-hover
  • backgroundSelectedHover: Gray-80-hover
  • layerHover01: Gray-80-hover
  • layerDisabled: remove?
  • layerAccentHover01: Gray-70-hover
  • layerAccentHover02: Gray-60-hover
  • fieldHover01: Gray-80-hover
  • fieldDisabled: remove?
  • iconDisabled: adjustAlpha(iconPrimary, 0.25);
  • skeletonBackground: Gray-90-hover
  • supportInfoInverse: Blue-70

Gray 100 theme

  • backgroundHover: Gray-100-hover
  • backgroundInverseHover: Gray-10-hover
  • backgroundSelectedHover: Gray-90-hover
  • layerHover01: Gray-90-hover
  • layerDisabled: remove?
  • layerAccentHover01: Gray-80-hover
  • fieldDisabled: remove?
  • textError: Red-40
  • iconDisabled: adjustAlpha(iconPrimary, 0.25);
  • supportInfoInverse: Blue-70
  • highlight: Blue 80
  • toggleOff: Gray 60

Button tokens

  • $button-danger-hover
    • themes.$white: #b81922 (Red 60 hover)
    • themes.$g10: #b81922 (Red 60 hover)
  • $button-primary-hover
    • themes.$white: #0050e6 (Blue 60 hover)
    • themes.$g10: #0050e6 (Blue 60 hover)
    • themes.$g90: #0050e6 (Blue 60 hover)
    • themes.$g100: #0050e6 (Blue 60 hover)
  • $button-secondary-hover
    • themes.$white: #474747 (Gray 80 hover)
    • themes.$g10: #474747 (Gray 80 hover)
    • themes.$g90: #5e5e5e (Gray 60 hover)
    • themes.$g100: #5e5e5e (Gray 60 hover)
  • $button-tertiary-hover
    • themes.$white: #0050e6 (Blue 60 hover)
    • themes.$g10: #0050e6 (Blue 60 hover)
Read more comments on GitHub >

github_iconTop Results From Across the Web

Design tokens – Material Design 3
Design tokens represent the small, repeated design decisions that make up a design system's visual style. Tokens replace static values, such as hex...
Read more >
Design tokens for dummies - UX Collective
Design Tokens are indivisible pieces of an interface like colors, font-sizes, spaces, animations, etc… They allow product teams to better collaborate and ...
Read more >
Design Tokens - Lightning Design System
Design tokens are the visual design atoms of the design system ... These RGBA values need to be updated if BRAND_BACKGROUND_DARK changes, solves...
Read more >
Design tokens - Adobe Spectrum
Design tokens are all the values needed to construct and maintain a design system — spacing, color, typography, object styles, animation, etc.
Read more >
Releases | Adjust Atlas
Update design tokens based on the new design language · Remove old "raised" and "lowered" object styles · Add button, input, elevation, tile...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found