question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update `size` prop in components to use consistent terms for size

See original GitHub issue

Currently size in component code are: image

But should be:

  • Small: 32px
  • Medium/default: 40px
  • Large: 48px

This issue is for updating the API of components that accept a size prop to follow this convention. If it’s possible, it would be preferred to add these options in as part of the existing API and deprecate existing options before we remove them in v11.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
tw15egancommented, Mar 22, 2021

@joshblack looking into it a bit more, it seems like we should be good just sticking with the current t-shirt sizes vs. the full name. This will also give us a bit more flexibility for adding xs variants ( extra-small is a bit cumbersome)

0reactions
joshblackcommented, Apr 14, 2021
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Build a Consistent Style Guide with React & styled ...
First, we can keep these variables where they are, in index.js. Then, we can pass them as props to every component. Second, we...
Read more >
Explore component properties - Figma Help Center
A variant property allows you to define attributes of your variants, such as state, color, or size. A component set contains multiple variants,...
Read more >
Sizing items in CSS - Learn web development | MDN
In the various lessons so far, you have come across a number of ways to size items on a web page using CSS....
Read more >
You Probably Don't Need Derived State – React Blog
If you're updating derived state unconditionally or updating it whenever props and state don't match, your component likely resets its state too ...
Read more >
Understanding Redux: A tutorial with examples
In this tutorial, we'll show you what Redux is, why you should use it, and how it works. We'll demo using a simple...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found