question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Row] please add prop to remove top margin

See original GitHub issue

Summary

All Row components in the main body of the page have a default margin-top value:

Screen Shot 2019-11-15 at 3 29 52 PM

These lines appear to be the cause:

https://github.com/carbon-design-system/gatsby-theme-carbon/blob/7ad684f52441975d4452d33d96cfd3093f7733b6/packages/gatsby-theme-carbon/src/components/Main/Main.module.scss#L11-L14

But unlike the Column component, there’s no prop to remove this spacing if needed.

We would like to have a prop we could use for the Row component that removes this margin value.

Justification

There are instances in IBM Security designs where there are no margins between rows, so we would like the flexibility to remove these margins easily without a messy style override.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
vpiconecommented, Nov 21, 2019

@jendowns yeah its nothing special about rows, that space just gets added to top level children. Wrapping the rows (or any group of elements) will prevent them from each getting the margin top.

Sorry for the break, it was a pretty big shift in how we handle vertical rhythm. I’d prefer wrapping the rows rather than adding a prop to each row, I’m not a fan of how copy-and-paste repetitive the column props are.

1reaction
jnm2377commented, Nov 15, 2019

I think either way, it would be fine to add an option to remove the margin since Column does that as well. But just wanted to you to know that the styles may be changing with this second space audit.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Removing margin from flex items when they wrap
So what you would do is use grid-gap for spacing between the items. Then use padding for the same spacing between the items...
Read more >
margin-top - CSS: Cascading Style Sheets - MDN Web Docs
The margin-top CSS property sets the margin area on the top of an element. A positive value places it farther from its neighbors,...
Read more >
Removing right/left content margins
Hello,. My client is asking to remove right and left margins from the applications and I cant find where, this is how it...
Read more >
margin | CSS-Tricks
Each of the margin properties can also accept a value of auto . ... to redefine any of the top margins to remove...
Read more >
How To Adjust the Content, Padding, Border, and Margins of ...
Add the following highlighted line to your CSS rule in your ... You can remove this margin by setting the top and left...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found