Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add comments to a generated playlist

See original GitHub issue

RFC 8216 allows for comments to be included in a manifest. They are any line that starts with a # and does not then have EXT as the following three characters. (section 4.1, paragraph 3)

Options

- (media playlist) Have all comments as a block immediately preceding the media segments.
- (master playlist) Have all comments as a block immediately preceding the renditions.
(both playlists) Attempt to introduce some ordering to the tags, allowing for comments between tags, and around media segments, renditions and variants.

Option (1) looks to be the easiest, however, (2) allows for more flexibility.

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:8 (7 by maintainers)

Top GitHub Comments

1reaction

brendonmosscommented, Jan 29, 2021

I’m needing to add some custom tags to the master m3u8, comments seems to be the best possible way to achieve this based on the flexibility in the RFC when not prefixed with EXT.

I am not too interested in maintaining a fork long term so ideally merging back in would be my preference else I can explore some manipulation to the output after building the manifest up and continue to use this package as it is right now.

let me know if you’re willing to review merge requests for changes around adding in Option 1 functionality. Thanks.

0reactions

carlantoncommented, Feb 20, 2021

fixed in #35