Removal of 👌 for code review changes

Hello @carloscuesta 😎!

• Emoji: 👌
• Code: :ok_hand:
• Description: Updating code due to code review changes.

I’d like to propose a removal of the emoji, added in https://github.com/carloscuesta/gitmoji/issues/93.

Reason: It is a bad practice to describe a VCS change as a code review change. Code reviews exist to reveal bugs, bad namings, usages, code performance etc. No change from a code review is made for no reason.

The flaws are there, they were just pointed out by the reviewer and they need to be fixed/refactored/optimized/… And it is that, which should be in the commit message. With appropriate emoji in our case.

[codemacabre]

I vote for removing the :ok_hand:, but only in terms of the emoji itself, not the concept of commits referring to code review changes. The emoji (and its physical hand gesture counterpart) has been corrupted by its misuse and appropriation as a symbol of hate (see https://selfdefined.netlify.com/#ok-hand).

Instead, I propose:

• 🦉 :owl: (my personal preference)
• 👁 :eye: or 👀 :eyes:
• 👁‍🗨 :eye_speech_bubble: (potentially problematic due to its origin)

I would argue that a dedicated gitmoji for code review changes is important, as there’s value in referring back to commits that were specifically changed due to a discussion with other developers. While these changes will have root reasons for being identified and changed, it should be the choice of author of the commit (or the development team) whether to identify the change as the root category (refactoring, optimising, etc.), or as a code review change.

[grissius]

Most likely in the long term, the whole PR is going to be squashed into a single one on merge anyway, so the individual commits are temporary.

A daresay this is not a common practice. When working on non-trivial projects, history development of feature branches is important.