TDD emoji: naive implementation of a test 😇

Hello @carloscuesta 😎!

• Emoji: 😇
• Code: :innocent:
• Description: When doing TDD, some people like to commit each step of the iteration (write the test, implement code to make the test pass, refactor). I’m looking for an emoji to represent when the code used to pass the test is a dummy, trivial version that does nothing but what the test expects.

[janainascal]

My initial ideia is to not change existing definitions, is to add one more to complete de steps of TDD. But I thing the meaning of ✅ (Add or update tests) is open enough so it could be the first or the second step.

I agree that 🧪 works better for the first step (“Add or update failing tests”), so we could use ✅ as the 2 step and change its definitions to “Add or update passing tests”. These change to not affect people who use git staging as @carloscuesta commented here

As you suggest, now I thinging about the three steps simultaneously:

1. 🛑 ✅ ♻️
2. 🧪 ✅ ♻️
3. ✅ 💩♻️
4. ✅ 😇 ♻️
5. ✅ 😅 ♻️
6. ✅ 🆗 ♻️
7. ✅ ⭕ ♻️
8. 🔴 🟢 ♻️

Obviously, I could write more combination, but my main ideia is to add, not change, so I would like to keep using ✅ as one step, thats why I do not like the option 8, although it works great. Option 3 is there to show we could work with existing gitmoji, but 💩 is not exactly true for step 2, we could write a good simple code and skeep step 3 (but is not the most probable scenario).

I like option 1 because it direct associate to RED, GREEN, REFACTOR. these is also why I don’t like option 7 My favorite is option 2 because: I associate 🧪 to test and we do not need to work in the 3 steps in sequence, many tests frameworks has the option to add failing tests to be fixing later on. These also encorage to write test as a bug report.

For example in an pure CI enviroment our commits can be mixed with other devs commits

• 🧪 write test
• 🐛 bug
• 🚧 another person commit
• ✅ my next day passing test commit

I dont like the ideia of changing already defined gitmoji, so I would not use ⚗️ “Perform experiments”

[carloscuesta]

Since ✅ means “add or update tests” today, adding the word “passing” to the definition seems really logical to me, though I’m curious what other folks think.

From an API pov, this is not a “breaking change” per se, as we’re making the applications of the emoji wider, right?

The proposal would be https://github.com/carloscuesta/gitmoji/issues/284#issuecomment-856862143

What do you think @vhoyer @johannchopin ?