Pushover priority parameter documentation

❓ Question

Hello,

I’m using apprise from the Docker image v0.7.1. My understanding of the documentation on https://github.com/caronc/apprise/wiki/Notify_pushover is that the priority parameter should be a string (low, moderate, normal, high, or emergency). However, that didn’t work. I found out that the priority should be passed as an integer instead (same as the Pushover API documented on https://pushover.net/api#priority).

Should the documentation be fixed or is the code misbehaving? (In my opinion, it makes sense to pass it as an integer, since it matches the Pushover API).

Thanks, Sylvain

[spasche]

I agree that it would be a better user experience if the parameters in YAML behave the same way as parameters from the URL.

I ran this command to check which plugins might be impacted by the same issue (i.e. the ones that use a map to convert from a string value to int):

rg -l --multiline  --multiline-dotall 'def parse_url.*_map' apprise/plugins/
apprise/plugins/NotifyGrowl.py
apprise/plugins/NotifyOpsgenie.py
apprise/plugins/NotifyD7Networks.py
apprise/plugins/NotifyProwl.py
apprise/plugins/NotifyNtfy.py
apprise/plugins/NotifyGotify.py
apprise/plugins/NotifyDBus.py
apprise/plugins/NotifyDapnet.py
apprise/plugins/NotifyPushover.py
apprise/plugins/NotifyGnome.py
apprise/plugins/NotifyJoin.py

So while it would be possible to modify the Pushover plugin, I think the better approach would be to refactor all plugins so that __init__ and parse_url share the same logic for converting parameters.

That would be a non-trivial refactoring of the codebase 😉

Maybe until this is all aligned, the documentation could warn about this discrepancy when specifying parameters as YAML properties.

[caronc]

Closing this ticket off as it’s resolved now 🚀🚀