Add rxjs-all-subjects-suffixed rule

I have another rule addition suggestion:

rxjs-all-subjects-suffixed (or rxjs-no-unsuffixed-subjects as per your naming convention), which enforces that subject names must be suffixed with Subject$ (also as per the Finnish notation rule).

e.g.

class Mock {
  private property$ = new Rx.Subject<any>();
          ~~~~~~~~~                   [Subject 'property$' must end with 'Subject$']
}

Let me know if this is also of interest to integrate. 😄

[cartant]

Yeah. In general, I’m happy to have rules added to the package. They don’t have to conform to my opinions - e.g. I’m not a fan of Finnish notation. My only criteria is that they should do what they’re intended to do in all circumstances - or, at least, with as few exceptions as possible.

When writing your new rule, you might want to have a look at Craig’s tsquery package. I favour it over using a walker and I’ve used to for all of my most recent rules, e.g.:

• https://github.com/cartant/rxjs-tslint-rules/blob/master/source/rules/rxjsNoCompatRule.ts
• https://github.com/cartant/rxjs-tslint-rules/blob/master/source/rules/rxjsNoIgnoredNotifierRule.ts

Search for tsquery( for more examples in this repo.

Craig has written about it here.

[cartant]

Also, with this one, I think it’ll be important for the suffix to be configurable - i.e. via an option.

And I’d try to keep the rule name as short as possible. Maybe rxjs-suffix-subjects?