question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow rxjs-no-patched to have exclusions?

See original GitHub issue

Hi there, amazing work on these rules first of all!

Is it possible to allow the rxjs-no-patched rule to have exclusions to the rule? My use case is on Observable.of, Observable.never, and the rest that are in rxjs/add/observable that I want to exclude out of the rule — having functions like never() and throw() in the codebase can be confusing and we disallow renaming imports from another lint rule already.

I’m thinking of the same syntax as rxjs-add’s file or a list of the patched methods to disallow. Let me know what you think.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
cartantcommented, Nov 27, 2017

Sounds reasonable. I’ll add it when I next have 15 or so minutes to spare.

0reactions
diagramaticscommented, Nov 27, 2017

That was fast, cheers!

Another thing you might wanna consider is having the same option setup in rxjs-no-add. Since rxjs/add/observable is going to be used in one patch import file, it might be necessary to exclude observable patching too.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add an exclusion to Windows Security - Microsoft Support
Under Virus & threat protection settings, select Manage settings, and then under Exclusions, select Add or remove exclusions. Where to add an exclusion...
Read more >
Background Information | Exclusions
Exclusions are imposed for a number of reasons: Mandatory exclusions: OIG is required by law to exclude from participation in all Federal health...
Read more >
What Is an Excluded Driver on a Car Insurance Policy?
Not all states allow policyholders to exclude household members from coverage. Get quote.
Read more >
About Exclusions: exclude specific audience segments from ...
Sign in to your Google Ads account. · Click the Audiences tab in the left page menu. · In the “Exclusions” module, you'll...
Read more >
Post-randomisation exclusions: the intention to treat principle ...
If the reason for exclusion was that they were expected to have a reduced or no ... The study protocol stipulates that only...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found