Not so opinionated analog of `rxjs-prefer-angular-takeuntil`, please
See original GitHub issueI’d like to suggest an idea of a bit less restrictive analog of rxjs-prefer-angular-takeuntil
.
Since there are a plenty of libraries offering some automation for creating and completing destroy subjects (https://www.npmjs.com/search?q=take until destroyed), I’d like to have a rule that only checks that .subscribe()
in component is preceded by .takeUntil()
(or any of its configurable aliases) in .pipe()
. And doesn’t check destroy subject, ngOnDestroy()
, .next()
and .complete()
calls, and whatever else rxjs-prefer-angular-takeuntil
currently checks.
Perhaps, might be achieved by adding more options to existing rxjs-prefer-angular-takeuntil
rule. Or by implementing a completely separate new rule. What do you think?
Issue Analytics
- State:
- Created 3 years ago
- Reactions:6
- Comments:9 (4 by maintainers)
Top Results From Across the Web
Opinionated Definition & Meaning - Merriam-Webster
The meaning of OPINIONATED is firmly or unduly adhering to one's own opinion or to preconceived notions. How to use opinionated in a...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yeah, that sounds pretty reasonable. 4.30.0 has been published and the rule now has
alias
andcheckDestroy
options.@anotherpit This should be fixed in 4.30.1 and
checkDestroy
should default tofalse
if analias
is specified.