Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Not so opinionated analog of `rxjs-prefer-angular-takeuntil`, please

See original GitHub issue

I’d like to suggest an idea of a bit less restrictive analog of rxjs-prefer-angular-takeuntil.

Since there are a plenty of libraries offering some automation for creating and completing destroy subjects ( until destroyed), I’d like to have a rule that only checks that .subscribe() in component is preceded by .takeUntil() (or any of its configurable aliases) in .pipe(). And doesn’t check destroy subject, ngOnDestroy(), .next() and .complete() calls, and whatever else rxjs-prefer-angular-takeuntil currently checks.

Perhaps, might be achieved by adding more options to existing rxjs-prefer-angular-takeuntil rule. Or by implementing a completely separate new rule. What do you think?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:6
  • Comments:9 (4 by maintainers)

github_iconTop GitHub Comments

cartantcommented, Mar 28, 2020

Yeah, that sounds pretty reasonable. 4.30.0 has been published and the rule now has alias and checkDestroy options.

cartantcommented, Apr 1, 2020

@anotherpit This should be fixed in 4.30.1 and checkDestroy should default to false if an alias is specified.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Opinionated Definition & Meaning - Merriam-Webster
The meaning of OPINIONATED is firmly or unduly adhering to one's own opinion or to preconceived notions. How to use opinionated in a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found