Map instantiation fails when map is created from shared dataset

Working on #9516 I faced a trouble related to the query and the map instantiation. Follow theses steps to reproduce it:

• Share a dataset with write permission. Don’t qualified the sql query (aka, include the username as part of the table name in the query).
• Using the user that it’s shared with, create a map from this dataset.
• 💥 Dashboard has some errors: Error: Map instantiation failed.

This is happening because the queries present in the vizJSON are not qualified with the owner’s username.

This is hard to fix in the frontend (in the right way) because the map is initially instantiated in the deep-insight (and cartodb.js) side, from the data coming from the vizJSON. I tried to patch the vizJSON to fix the queries, and it solves the issue, but the solution smells. I feel the queries should come qualified in the vizJSON, in the same manner as table_name properties.

[javitonino]

Final decision after some offline discussion. On map creation we will reset the styles from the dataset, but keep the query that’s been applied (in order to avoid surprises when going from the dataset preview to create a new map). So basically, we are just keeping the query, rewritten. Of course, this is toggled by builder activation.

This is being done in #9749 (queries) and #9726 (styles).

[javitonino]

Agreed. I dislike having add layer creating the layer options in frontend and map creation doing it in backend, but I think the best solution for doing thing at creation time is in the backend.

Note that for this issue we will have to check if the builder is enabled or not to toggle the behaviour, as we want to keep the old behaviour (copy map with TableBlender) for the editor.