question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move builder activation to builder_enabled flag

See original GitHub issue
  1. Remove builder_enabled box toggle, via #10067
  2. Add builder_enabled to Organization model, and set NOT NULL, via #10188
  3. Disable builder FF for users with disabled builder. In the box create a listing Carto::User.where(builder_enabled: false).select(&:builder_enabled?) and disable flag in Central.
  4. Start accepting builder_enabled updates from Central, via #10190
  5. Copy the values from FF, Carto::User.find_each { |u| u.update_column(:builder_enabled, u.builder_enabled?) } (this will disable the builder for anyone who doesn’t have the FF set).
  6. Update User model functions to stop reading the FF and just check the attribute instead, via #10189
  7. Make Central stop setting the FF (now it is being copied from the attribute on save). via CartoDB/cartodb-central#1530
  8. Remove feature flag

Note: Currently builder_enabled? is a method that checks the FF, builder_enabled is the attribute.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
javitoninocommented, Oct 14, 2016
  • Just from the UI. Yes, we want Central to be the authoritative source for builder_enabled, not the user. And we are not syncing from the box to central. So I think the best way is to disable the option to change this before syncing.
  • That code snippet is setting builder_enabled attribute from the feature flag (which is builder_enabled? ending in ?).

And you are right about that steps, that is roughly the idea.

0reactions
juanignacioslcommented, Oct 18, 2016

🐔

(just kidding)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Respawn Checkpoint Flags (Game Builder Garage Tutorial)
Today we are going to add not only one but two checkpoints to our game in Game Builder Garage. We Start by creating...
Read more >
Change Logs - Beaver Builder
License activation has been moved from Settings > FastLine Themes to Settings > Page Builder > License. The builder is now disabled by...
Read more >
SFMC Known Issues - sprignaturemoves
Using the Journey Builder API it is possible to activate a version of a journey in a non-draft state such as stopped. This...
Read more >
What's in a flag? Subliminal exposure to New Zealand ...
What's in a flag? Subliminal exposure to New Zealand national symbols and the automatic activation of egalitarian versus dominance values · Authors ·...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found