Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use CartoColor in input color fields

See original GitHub issue

Context

We are currently using a hardcoded ramps object in Builder to display the different available color ramps in markers color input. This can be found in this file.

However, I think it is better to get the ramps from our CartoColor library in order to be more consistent. This is the approach we have followed in this PR for qualitative values. In my opinion, we should remove this file and use CartoColor instead.

What do you think?

Steps to Reproduce

Create a new / use an existing map
Go to Style
Click on input color
Click on Style by value

captura de pantalla 2018-02-01 a las 14 49 28

Current Result

Color ramps are being taken from a hardcoded ramps.js file.

Expected result

Color ramps should be taken from CartoColor.

Additional info

In the PR mentioned above, we have created a helper to get ramps by name and number of required colors.

Issue Analytics

State:
Created 6 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

makellacommented, Feb 23, 2018

hey @elenatorro!

so let’s not use those old ones in ramps.js!

take a look why in this presentation slide

In that green palette, look at what we were doing! bad, bad…

I have always wanted Builder to read in the names of the schemes instead listing out the color values as seen here: https://github.com/CartoDB/cartodb/issues/9528

We have to also consider the “flipping” option that we currently have and how we would read in the inverse of the scheme when that is done (gif below).

Ideas here: https://github.com/CartoDB/turbo-carto/issues/35

flip-ramp