Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move client parameter to header

See original GitHub issue

Feature request:

We are adding a client parameter to map instantiation to know who is doing that instantiation. CARTO VL: map?client=vl-0.9.2 CARTO.js: map?js=js-4.0.9

This implies that everytime we publish a new version, the cache invalidates.

As @dgaubert suggested, we should move this to a request header, to be able to gather metrics about who our users are and respect the map cache.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

dgaubertcommented, Jul 11, 2018

You are right. This is a clear Won't fix.

Closing then.

rochoacommented, Jul 10, 2018

More reasons to not do this:

  1. If we don’t change every layer to be aware of the header, we won’t be able to get the header with the version at the application layer. That means that any intermediate layer (CDN, nginx, varnish) should be aware of that header in order to let it pass. That means adding new functionality to handle the header in all the layers between the browser/client and the application server.
  2. If you have to do that, you will be hitting the application layer again. So all the effort to not use a query parameter in the URL will vanish because you have to hit the application layer to be able to log that header. Something you got for granted by just simply using the query parameter.
  3. Even more, with the new header, you won’t be able to cache anymore any request because you have to let pass all of them to log them at the application layer.
Read more comments on GitHub >

github_iconTop Results From Across the Web

HTTP/1.1: Header Field Definitions
For entity-header fields, both sender and recipient refer to either the client or the server, depending on who sends and who receives the...
Read more >
How to modify, mask or remove parameters and header fields ...
How to modify, mask or remove parameters and header fields using the API Connect Redact policy and gateway scripts.
Read more >
Header parameters: "Accept" and "Content-type" in a REST ...
I understand that the Accept parameter define a data type expected in a client response sent from the server, so it's used as...
Read more >
header - Manual - PHP
A quick way to make redirects permanent or temporary is to make use of the $http_response_code parameter in header(). <?php // 301 Moved...
Read more >
HTTP headers - MDN Web Docs - Mozilla
HTTP headers let the client and the server pass additional ... Specifies the transfer encodings the user agent is willing to accept.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found