SVGs with missing width, height and viewbox cause errors

If you try to add an SVG file without a width, height and viewBox element, the script returns an error exactly where it should report the missing file.

The file variable is used in a previous Promise function, but is no longer available (since the code has gone to a new then node).

I might write a PR for this, but don’t have the time right now.

https://github.com/cascornelissen/svg-spritemap-webpack-plugin/blob/93b68de6d99975c01945816eea8c7d858ac7ead6/lib/generate-svg.js#L131

A hotfix is to replace this line with a return; statement, but it’s not helping anyone solve the issue.

[roelofr]

Sorry @cascornelissen for the delay, the project I was using it in had taken a sharp turn when I spent too much time figuring this out.

I re-tried it in a different project (gumbo-millennium/website) and added this invalid SVG:

<svg xmlns="http://www.w3.org/2000/svg">
    <path fill="red" d="M0 0h64v64H0z"/>
</svg>

The result looks promising:

Error: Invalid SVG '/home/roelof/dev/gumbo/resources/assets/icons/square.svg'; it's lacking both a
 viewBox and width/height attributes...

edit

However, it also seems that WebPack isn’t too fond of not using Promise.catch, since it also spits out this beauty:

UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting
 a promise which was not handled with .catch(). (rejection id: 1)

[cascornelissen]

@alpezed, I’m not 100% I understand but the svg-spritemap-webpack-plugin needs to know the height and width of each SVG that you want to end up in the spritemap. Without knowing the width/height of an SVG file it can’t calculate where the file should be placed in the generated spritemap.