`AndroidSqliteDriver.Callback` class is final

SQLDelight Version

2.0.0-alpha04

Operating System

MacOS 12.6

Gradle Version

7.5

Kotlin Version

1.7.20

Dialect

app.cash.sqldelight:sqlite-3-18-dialect

AGP Version

7.3.0

Describe the Bug

Hello

On the version 2.0.0-alpha04 the class AndroidSqliteDriver.Callback is marked as final which make impossible to override the onCreate, onUpgrade, onConfigure, onOpen, etc…

For instance, this code doesn’t compile:

AndroidSqliteDriver(
        schema = Database.Schema,
        context = context,
        name = "my_db.db",
        callback = object : AndroidSqliteDriver.Callback(Database.Schema) {
            override fun onOpen(db: SupportSQLiteDatabase) {
                db.execSQL("PRAGMA foreign_keys=ON;")
            }
        }
    )

Regards

Stacktrace

No response

Gradle Build Script

plugins {
    id 'com.android.library'
    id 'org.jetbrains.kotlin.android'
    id 'org.jetbrains.kotlin.kapt'
    id 'app.cash.sqldelight'
}

dependencies {
    api "app.cash.sqldelight:android-driver:$sqlDelightVersion"
    api "app.cash.sqldelight:coroutines-extensions-jvm:$sqlDelightVersion"
    api "app.cash.sqldelight:primitive-adapters:$sqlDelightVersion"
}

sqldelight {
    Database {
        packageName = "com.masselis.tpmsadvanced.data.car"
        verifyMigrations = true
        schemaOutputDirectory = file("src/main/sqldelight")
        dialect("app.cash.sqldelight:sqlite-3-18-dialect:$sqlDelightVersion")
    }
}

[svenjacobs]

Facing the same issue in 2.0.0-alpha04 because I want to implement onConfigure to enable foreign keys like

override fun onConfigure(db: SupportSQLiteDatabase) {
    db.setForeignKeyConstraintsEnabled(true)
}

The solution above with a delegate works but this was much less boiler plate code in version 1.5 of SQLDelight.

[VincentMasselis]

Thanks, I didn’t thought that I could just do that, I’ve applied this fix on my code until the next release 😃