Failed to compile InsertStmtImpl(INSERT_STMT)

Build Environment SQLDelight version: 1.4.0 SQLDelight plugin version: 1.4.0 OS: Linux Gradle version: 6.5 Kotlin version: 1.3.72

I just updated to 1.4.0 from 1.3.0 and now my build fails on this statement:

CREATE TABLE MediaError(
  id TEXT AS MediaId PRIMARY KEY NOT NULL REFERENCES Media(id),
  error TEXT AS MediaErrors NOT NULL,
  stacktrace TEXT DEFAULT NULL
);

upsert:
INSERT INTO MediaError(
  id, error, stacktrace
)
VALUES (
  :id, :error, :stacktrace
)
ON CONFLICT(
  id
)
DO UPDATE SET
  error = :error,
  stacktrace = :stacktrace;

The error is:

> Failed to compile InsertStmtImpl(INSERT_STMT): [] :
  INSERT INTO MediaError(
    id, error, stacktrace
  )
  VALUES (
    :id, :error, :stacktrace
  )
  ON CONFLICT(
    id
  )
  DO UPDATE SET
    error = :error,
    stacktrace = :stacktrace

My gradle file:

sqldelight {
  database("MyDatabase") {
    packageName = "com.me.models.sqldelight"
    sourceFolders = listOf("sqldelight-models", "sqldelight-migrations")
    schemaOutputDirectory = file("src/main/sqldelight-migrations")
    dialect = "sqlite:3.24"
  }
}

I tried killing the gradle daemon, and that didn’t help.

If I remove ON CONFLICT... it compiles.

[veyndan]

@felipecsl That’s a different issue than the one @eygraber is describing, as the PostgreSQL grammar defined in sql-psi currently does not support upsert (whereas sqlite:3.24 which is being used by @eygraber should be working as it’s defined in the respective sql-psi grammar file).

Please feel free to open a separate issue (ideally in the sql-psi repo) so your issue doesn’t get lost in this one.

[eygraber]

@AlecStrong this is blocking us from updating to Kotlin 1.4. Any help / pointers would be much appreciated 😄

I tried looking into it myself, and everything works if I change the statement to:

upsert:
INSERT INTO MediaError(
  id, error, stacktrace
)
VALUES (
  :id, :error, :stacktrace
)
ON CONFLICT(
  id
)
DO UPDATE SET
  error = 'error',
  stacktrace = 'some stacktrace';

Obviously that wouldn’t work in reality.

Looking at the stacktrace, it seems like there needs to be another type handled in SqlSetterExpression.argumentType but I’m not sure which one it should be. Maybe UpsertDoUpdate?