Bookmark position is wrong after seeking to end
See original GitHub issueBug report
Your Environment
- Netflix add-on version: 1.10.1
- Operating system version/name: Raspberry Pi OS (Debian Buster)
- Device model: Pi 4
Used Operating system:
- Android
- iOS
- Linux
- OSX
- Raspberry-Pi
- Windows
Describe the bug
I typically seek to end (usually up arrow, +10 minutes) to stop the videos, this was working fine up until recently. What seems to happen now is the video shows as partially watched (about 10 minutes). My guess is this is related to commit a24c548ecee761790096ce8593af764b22323acd, as what Kodi thinks is the bookmark position is the amount that I seeked. This also happens if I do right arrow 3 or 4 times (it will be around 2-3 minutes as the bookmark position).
This seems to be cosmetic/caching on the addon side, because on Netflix the bookmark position shows around ~39 minutes which is around where I used the seek.
Expected behavior
Bookmark position on Netflix & Kodi should be runtime of video.
Actual behavior
Bookmark position on Kodi is roughly the amount of time seeked forward. On Netflix it is the time in the video where I seeked forward (probably the last keepAlive?).
Steps to reproduce the behavior
- Start video
- Seek to a few minutes before end
- Let keepAlive event go out
- Seek to end
Possible fix
Debug log
The debug log can be found from this link: kodi.log
Additional context or screenshots (if appropriate)
Installation
- I’m using other Netflix Repo: CastagnaIT
- I’m using a different source
Other information
I have also occasionally received this back trace, but I haven’t been able to reproduce it yet with debugging:
2020-10-25 17:54:54.167 T:2666516688 ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
File "/home/kodi/.kodi/addons/plugin.video.netflix/resources/lib/services/playback/action_controller.py", line 90, in onNotification
self._on_playback_seek(json.loads(data)['player']['seekoffset'])
File "/home/kodi/.kodi/addons/plugin.video.netflix/resources/lib/services/playback/action_controller.py", line 138, in _on_playback_seek
player_state = self._get_player_state(time_override=time_override)
File "/home/kodi/.kodi/addons/plugin.video.netflix/resources/lib/services/playback/action_controller.py", line 199, in _get_player_state
player_state['percentage'] = player_state['percentage'] / player_state['elapsed_seconds'] * elapsed_seconds
ZeroDivisionError: float division by zero
This I suspect is related to the same commit mentioned earlier.
Screenshots
Issue Analytics
- State:
- Created 3 years ago
- Comments:13 (10 by maintainers)
Top GitHub Comments
@fernandog I saw the video and you are talking about the Kodi player this add-on has no control over the playback
so your problem must be reported on Kodi, then not here, i can do nothing here
if you are using some kind of Kodi OS like CoreElec you have to report to they repository/forum if you are using non-original skins before report you have to switch/test on the original Kodi skin
That’s the change I did as well and it’s been working on Kodi 18.9 with no problems.