Deprecating Resolve(Type, IDictionary) in favor of IReadOnlyDictionary<string, object>

Right now it’s a bit of a pain to use the Resolve method because what I’ll have in hand is an IReadOnlyDictionary<string, object>, usually from a method parameter.

Please consider adding this method and removing the nongeneric overload.

The nongeneric one would be a problem. So long as it’s there and you pass it a type like Dictionary<string, object> which implements both interfaces, which all of the BCL dictionaries do, you’ll have to disambiguate the overload by explicitly casting to one or the other interface type.

This would be a breaking change for people still using non-generic dictionaries like Hashtable, and there may be a few, so what if you removed it in v5?

[ghost]

@jnm2

The extension Arguments.FromReadOnlyDictionary now calls a shallow copy constructor here.

I think this coupled with making Arguments readonly for any side effects when it comes to calling Add, Clear or Remove by setting isReadOnly here gets you what you need.

It is also a tidy way of getting rid of bad methods as it turns out 😃

[jonorossi]

@fir3pho3nixx thanks for looking into this more, I had just thought we’d do as @jnm2 suggested and implement it at the API surface level but this is something we’ll definitely need to look at more.

If Windsor does mutate the user’s dictionary then we could probably implement copy-on-write using the cheshire cat pattern or something similar so the Windsor internals are none the wiser that they were even passed a readonly dictionary.

However, we’ve already got copy-on-write with the overload that takes an anonymous type which Windsor obviously can’t modify, Windsor uses the ReflectionBasedDictionaryAdapter to read the contents and methods like Add throw a NotImplementedException, maybe some consolidation of code paths:

object Resolve(Type service, object argumentsAsAnonymousType);