Typed factory should allow disposing multiple times

According to .NET Guidelines a dispose method should tolerate being called multiple times without throwing an exception.
This exception should not be thrown when method equals FactoryMethod.Dispose:

https://github.com/castleproject/Windsor/blob/603d78d491790c88cff604051c92115e8bb5d9f9/src/Castle.Windsor/Facilities/TypedFactory/Internal/TypedFactoryInterceptor.cs#L55

[jonorossi]

Therefore, I’d say that not only the second call to Dispose should be ignored by this interceptor, but also calls to Release method as well after the factory had been disposed.

I can make a PR with the changes and some tests if needed.

@ivan-danilov makes sense. I think I was misunderstanding the situation like @mjacobs80 also has:

Basically the order the components are being disposed is not guaranteed hence Dispose being called twice on the factory.

[mjacobs80]

I just fell into this and it looks like no progress has been made on this one. Following the documentation about the TypedFactory (https://github.com/castleproject/Windsor/blob/master/docs/typed-factory-facility-interface-based.md) I’ve created a factory interface that inherits IDisposable.

I have a component that implements IDisposable, it has an interface based TypedFactory injected in the constructor and it’s Dispose is called in the components Dispose.

Reviewing the stack trace the exception happens when I’ve called Dispose on the container itself which looks to match what @ivan-danilov encountered. Basically the order the components are being disposed is not guaranteed hence Dispose being called twice on the factory.

Playing with lifestyles I can confirm that If the component that uses the factory is Transient it doesn’t have this issue as a release on a Transient calls it’s Dispose (if implemented) immediately. I’ve not tested what happens if we don’t Release explicitly before calling Dispose on the container.

I’ve got to do some further work checking behaviour under WCF as the component in this case is the service implementation which will be PerWbRequest or PerWcfOperation in many cases. I simply encountered this during unit testing where we’ve registered using the default lifestyle.

This all said throwing an exception from a Dispose is not expected. As @jonyadamit pointed out, throwing exceptions from Dispose is not in accordance with .NET guidance about allowing dispose to be called multiple times, here is a link about this from plurasight https://www.pluralsight.com/blog/software-development/idisposable-for-dummies-1-why-what

TypedFactory doesn’t expose a property to check if it is already disposed, and I don’t want to roll my own implementation on the interface as I want interface based typed factories. This appears to leave the only option to remember to put a try catch around it to deal with it robustly in situations where we’d want a component to be a Singleton.