Pyserini package/module structure: unnecessary nesting?

Current invoking is something like:

from pyserini.search import pysearch
searcher = pysearch.SimpleSearcher('lucene-index.robust04.pos+docvectors+rawdocs')

@zeynepakkalyoncu @emmileaf don’t you think we have one unnecessary nested layer?

Would something like this make more sense?

from pyserini import search
searcher = search.SimpleSearcher('lucene-index.robust04.pos+docvectors+rawdocs')

or

from pyserini.search import SimpleSearcher
searcher = SimpleSearcher('lucene-index.robust04.pos+docvectors+rawdocs')

[emmileaf]

I think the submodule was originally there to mirror the java structure:

• pyserini.search corresponds to java/io/anserini/search and would contain every module that we want to bridge from there.
• pysearch.py was intended to mirror SimpleSearcher.java, which is the only module we have bridged to pyserini for now

If we don’t plan to extend anything else over from java/io/anserini/search in the near future, we can probably get rid of the submodule? Otherwise I’d second @zeynepakkalyoncu’s suggestion to perhaps rename pysearch.py to something like simple_searcher.py.

[lintool]

@emmileaf re: future proofing when modules grow too big. Agreed. You’ve convinced me - let’s keep the sub-packages. You were right all along! 😃

Closing issue.