installation fails on crc32c setup (Windows 10)

System info:

Windows 10 ver.1903, x64
python ver. 3.8.3, build MSC v.1916 64 bit (using conda)

Running pip install -U catalyst fails at the crc32 setup stage:

Building wheel for crc32c (setup.py) ... error
  ERROR: Command errored out with exit status 1:
...
ERROR: Failed building wheel for crc32c

Apparently, the crc32 module doesn’t build against Visual Studio, see https://github.com/ICRAR/crc32c/issues/1. However, VS builds are default on Windows systems for python.

I wonder if the crc32c module is necessary at all. For example, there’s some crc32 functionality in the binascii module, e.g.:

import binascii
buf = open("my_file.zip","rb").read()
print( binascii.crc32(buf))

Wouldn’t it be sufficient? Thanks!

[velikodniy]

Oh! I’ve just realized that I implemented it already in tensorboardX https://github.com/lanpa/tensorboardX/pull/429. 😄 We can use crc32c from this library until we drop it from dependencies and replace with torch.tensorboard (if we do).

So, all we need is ~love~ to replace this one

if os.environ.get("CRC32C_SW_MODE", None) is None:
    os.environ["CRC32C_SW_MODE"] = "auto"
from crc32c import crc32 as crc32c  # noqa: E402

with this one:

from tensorboardX.crc32c import crc32c

Don’t forget to remove crc32c from the dependencies and make a note in the README file about speedup if the library is installed.

[Scitator]

fixed during https://github.com/catalyst-team/catalyst/pull/872