Exposing `PhoneNumberType` similar to google-libphonenumber

We use google’s exported PhoneNumberType in a project I work on. We’d like to replace google’s large library with yours but it does not expose this property.

google-libphonenumber has an exported enum:

export enum PhoneNumberType {
    FIXED_LINE = 0,
    MOBILE = 1,
    FIXED_LINE_OR_MOBILE = 2,
    TOLL_FREE = 3,
    PREMIUM_RATE = 4,
    SHARED_COST = 5,
    VOIP = 6,
    PERSONAL_NUMBER = 7,
    PAGER = 8,
    UAN = 9,
    VOICEMAIL = 10,
    UNKNOWN = -1
}

Steps to reproduce

1. Try importing NumberType from libphonenumber-js.

Observed result

Import is not the same as google-libphonenumber since NumberType in libphonenumber-js is just the typescript type and not a concrete value.

Expected result

libphonenumber-js should expose the phone number types as an array, map, or enum etc…

I can try to create a PR if necessary. Thanks for looking into this.

[catamphetamine]

Hmm, I guess we could export that. Something like:

export enum PhoneNumberType {
    FIXED_LINE = 'FIXED_LINE',
    MOBILE = 'MOBILE',
    FIXED_LINE_OR_MOBILE = 'FIXED_LINE_OR_MOBILE',
    TOLL_FREE = 'TOLL_FREE',
    PREMIUM_RATE = 'PREMIUM_RATE',
    SHARED_COST = 'SHARED_COST',
    VOIP = 'VOIP',
    PERSONAL_NUMBER = 'PERSONAL_NUMBER',
    PAGER = 'PAGER',
    UAN = 'UAN',
    VOICEMAIL = 'VOICEMAIL',
    UNKNOWN = 'UNKNOWN'
}

Would that work?

[maurer2]

Hello, I believe this issue could be solved using const assertion in typescript 3.4+.

export const numberTypes = ['PREMIUM_RATE', 'TOLL_FREE', 'SHARED_COST', 'VOIP', 'PERSONAL_NUMBER', 'PAGER', 'UAN', 'VOICEMAIL', 'FIXED_LINE_OR_MOBILE', 'FIXED_LINE', 'MOBILE'] as const
export type NumberType = typeof numberTypes[number]

NumberType basically stays the same but is now derived from a readonly tuple. numberTypes can be exported and iterated over as proposed in https://github.com/catamphetamine/libphonenumber-js/issues/392#issuecomment-696700234.

Cheers