question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

typings for formatNumber

See original GitHub issue

Hey I notice you have been doing some refactoring, as far as I can see the formatNumber typings seem to be missing the options that can be passed e.g. { fromCountry: CountryCode, humanReadable: boolean }. Am I not understanding something here? Also I used to pass IDD: NumberFormat as the second argument, but the types show it should be CountryCode

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
catamphetaminecommented, Nov 1, 2018

Hi. I’m not myself a TypeScript user, the original typings were submitted by contributors. When I’m refactoring something I usually edit the typings but since I don’t test them there can be (and often are) some bugs. So, you can modify the typings, test them in your IDE, and then submit a pull request which we then can merge.

0reactions
catamphetaminecommented, Jan 7, 2019

@audiolion Yeah, I just thought that I’d wait until you check them out to not confuse other people in case there was some syntax error or something.

I am not using a ton of pieces of the api, but definitely using the core ones

Yeah, no need for the full api testing of course. Just see if it works at all and doesn’t break everything and that will be enough. You know, could be a missing bracket or something.

Read more comments on GitHub >

github_iconTop Results From Across the Web

VBScript FormatNumber Function - W3Schools
The FormatNumber function returns an expression formatted as a number. Syntax. FormatNumber(Expression[,NumDigAfterDec[, IncLeadingDig[,UseParForNegNum[, ...
Read more >
Format number in US Phone number format while typing in the ...
I got some help but it was used to format after complete typing the 10 digits. Used Regex format and ToString() formatting.
Read more >
FormatNumber Function [VBA] - LibreOffice Help
Returns a string with a number formatting applied to a numeric expression. ... This constant, function or object is enabled with the statement...
Read more >
Format Number, Currency, and Date/Time Fields - CustomGuide
Typing a series of formatting characters by hand in the Format box (the more difficult way). Format Number, Currency, and Date Fields. In...
Read more >
TypeScript number Data Type - TutorialsTeacher
This function has one optional argument, an integer specifying the number of digits after the decimal point. It returns a string representation of...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found