`react-hook-form` component typings seem to be incorrect

The default import from 'react-phone-number-input/react-hook-form' has type any.

I assume this is because the type

type PhoneInputWithCountrySelectType<InputComponentProps = DefaultInputComponentProps, FormValues> = React.ComponentClass<Props<InputComponentProps, FormValues>, State<Props<InputComponentProps, FormValues>>>

is incorrect.

First of all, the type parameter FormValues follows an optional type parameter, which is not allowed in TypeScript.

In addition to that, FormValues is a required parameter, but the component type uses PhoneInputWithCountrySelectType without any parameters.

declare const PhoneInputWithCountrySelect: PhoneInputWithCountrySelectType;

As a result, it seems that TS cannot parse that and assigns any as the type.

As a workaround, I have swapped the parameters and assigned {} to FormValues, as I have no idea what it’s supposed to be, and it works.

[finkrer]

@catamphetamine Actually, I just found out that there’s a new TS feature that allows you to fix a generic function’s type. So you can just write typeof PhoneInput<CustomProps, CustomFormValues> now.

In that case, we don’t need the export. Just move the generic to the right and it should all work great.

[finkrer]

@catamphetamine It can be, it’s just that giving a type for the user’s wrapper component is not something you need to do. In my code base, most components are typed as FC<Props, Something>. Obviously I wouldn’t want a library trying to make me use something else. Especially since in my case FC is a custom type as well, so you can’t use it like that.

So, I don’t need a PhoneInputComponentType for my wrapper component, I just need a PhoneInputType to represent your component in case I need it.