Unhelpful error message with circular dependency (part 2)

related to https://github.com/catkin/catkin_tools/issues/229 but that was closed despite https://github.com/catkin/catkin_tools/issues/229#issuecomment-245881842 showing the fix didn’t work (and that was catkin 0.4.2, I’m also seeing the bug with 0.4.3):

[build] Found '68' packages in 0.0 seconds.
Traceback (most recent call last):
  File "/usr/bin/catkin", line 9, in <module>
    load_entry_point('catkin-tools==0.4.3', 'console_scripts', 'catkin')()
  File "/usr/lib/python2.7/dist-packages/catkin_tools/commands/catkin.py", line 267, in main
    catkin_main(sysargs)
  File "/usr/lib/python2.7/dist-packages/catkin_tools/commands/catkin.py", line 262, in catkin_main
    sys.exit(args.main(args) or 0)
  File "/usr/lib/python2.7/dist-packages/catkin_tools/verbs/catkin_build/cli.py", line 419, in main
    summarize_build=opts.summarize  # Can be True, False, or None
  File "/usr/lib/python2.7/dist-packages/catkin_tools/verbs/catkin_build/build.py", line 305, in build_isolated_workspace
    packages, context, workspace_packages)
  File "/usr/lib/python2.7/dist-packages/catkin_tools/verbs/catkin_build/build.py", line 98, in determine_packages_to_be_built
    workspace_package_names = dict([(pkg.name, (path, pkg)) for path, pkg in ordered_packages])
AttributeError: 'str' object has no attribute 'name'

possibly also related to https://github.com/catkin/catkin_tools/issues/429 but not sure since it’s not hanging

[kopp]

When you found the right place: Do you think that you can make this a change with pull request?

[mikepurvis]

Should be fixed by #641.