Boolean parameters flips on multiple parse

I looked in the documentation to see if this is intended, but I don’t think it is. I recently upgraded from version 1.48 to 1.72 and noticed that boolean parameters would now toggle between true and false when parsed multiple times.

public class Parameters
{
    @Parameter(names = {"-f" }, description = "flag" )
    private boolean flagged = false;
}

public void parameterTest()
{
    Parameters parameters = new Parameters();
    JCommander jCommander = new JCommander( parameters );
    jCommander.parse( "-f" );

    Assert.assertTrue( parameters.flagged );

    jCommander.parse( "-f" );

    Assert.assertTrue( parameters.flagged ); //this fails
}

[sschuberth]

Just checking, @cbeust: Given (Kotlin) code like

@Parameter(description = "Enable debug logging and keep any temporary files.",
        names = ["--debug"])
private var debug = false

are you saying that specifying --debug --debug is intended to toggle debug to false again? I believe that behavior is very unintuitive. Because that’s the behavior we’re seeing with JCommander 1.74.

[cbeust]

That’s expected: boolean parameters have by definition an arity of zero: you only need to pass -v to flip it. Any additional parameter will be interpreted further.

If you want to support -v true, you need to set its arity to one.