Private @Before* methods aren't called when defined in a base class

TestNG Version

6.14.3 and 7.0.0-beta3, Java 8 and 11

Actual behavior

Private @Before* methods aren’t called when defined in a base class, but work when defined in the same class.

Expected behavior

Private @Before* methods should be called, whether they were inherited or not

Is the issue reproductible on runner?

• Shell
• Maven
• Gradle
• Ant
• Eclipse
• IntelliJ
• NetBeans

Test case sample

Following test passes - calls @BeforeMethod

public class NoInheritanceTest {
    boolean called = false;

    @BeforeMethod
    private void init() {
        called = true;
    }

    @Test
    public void testWorks() {
        assertTrue(called, "Should have been set in @Before");
    }
}

Following test fails - @BeforeMethod is not called:

public class ChildTest extends BaseTest {
    @Test
    public void testFails() {
        assertTrue(called, "Should have been set in @Before");
    }
}

public class BaseTest {
    boolean called = false;

    @BeforeMethod
    private void init() {
        called = true;
    }
}

Test case project: https://github.com/zhogov/testng-issue-2097

[Proryanator]

Ah I see, those private methods I mentioned are just for methods in general.

Yeah you’re right, somewhere outside of there you’d need to also check if they’re TestNG annotated methods before showing the warning, good catch!

[juherr]

#473 has a similar title but looks a bit different.

@Proryanator At our side, only console warnings are possible but IDEs can manage a better display if they want to warn against this bad usage (ping @missedone @akozlova )