Bitfinex order history limit

• OS: Linux
• Programming Language version: PHP
• CCXT version: 1.18.923
• Exchange: Bitfinex and Bitfinex2
• Method: fetchClosedOrders

Bitfinex has a parameter ‘limit’ (https://docs.bitfinex.com/reference#rest-auth-orders-history) which doesn’t work when passing under params. This code only returns 93 orders… (there are def more than 93 orders on the exchange).

            $closedOrders = $exchange->fetchClosedOrders($market, null, 500, ['limit' => 500]);

Bitfinex2 crashes out with:

privatePostOrdersHist method not found, try underscore_notation instead of camelCase for the method being called.

[LeighBicknell]

Well, technically, we accept JavaScript only, however, if you open the JavaScript fetchClosedOrders and the PHP fetchClosedOrders and compare them, you will immediately notice 0 differences

This is exactly what I was looking for.

I’m comfortable enough with Javascript. If I get a spare few hours i’ll look deeper into it all 😃

Thanks for all your help.

[kroitor]

@FlickerBean thx! We appreciate all PRs and contributions!

Where can I get more information on how to contribute via php

Here:

• https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#multilanguage-support

is this possible or are contributions to exchanges only allowed via Javascript due to the transpiling?

Well, technically, we accept JavaScript only, however, if you open the JavaScript fetchClosedOrders and the PHP fetchClosedOrders and compare them, you will immediate notice 0 differences:

↑ That code is literally the same line-to-line. That is because the code is designed to be portable. So, if you don’t feel confident with JavaScript, but you can code in PHP – you could still implement the proper method in JS just by copy-pasting the existing code.

When writing the new code we stick to these rules:

• https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#derived-exchange-classes

I have read https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md before. But it doesn’t make everything 100% clear.

Let us know if you have specific questions, will be happy to answer )