[BUG] Problem importing knative CRDs

Describe the bug I’m trying to import the KNative serving CRD from https://github.com/knative/serving/releases/download/v0.14.0/serving-crds.yaml

I get the following error:

TypeError: Cannot read property 'kind' of null
    at /usr/local/lib/node_modules/cdk8s-cli/lib/import/crd.js:81:34
    at Array.filter (<anonymous>)
    at Function.match (/usr/local/lib/node_modules/cdk8s-cli/lib/import/crd.js:81:14)
    at async matchImporter (/usr/local/lib/node_modules/cdk8s-cli/lib/import/dispatch.js:23:17)
    at async Object.importDispatch (/usr/local/lib/node_modules/cdk8s-cli/lib/import/dispatch.js:7:26)
    at async Object.handler (/usr/local/lib/node_modules/cdk8s-cli/bin/cmds/import.js:27:9)

There are a couple of other things worth noting. Firstly, there is no following of redirects on download of HTTP resources (so using that URL doesn’t work). Secondly, as you can see there is no clear idea of where in the imported CRD the problem lies.

To Reproduce Since redirects don’t work, I downloaded the crd like this:

wget https://github.com/knative/serving/releases/download/v0.14.0/serving-crds.yaml

Here is my cdk8s.yaml

language: typescript
app: node main.js
imports:
  - k8s@1.17.0
  - serving-crds.yaml

And then I run cdk8s import

Expected behavior It to work as the CRD example.

Additional context I’ve tried a couple of other CRDs and they work fine.

[eladb]

thanks for the report. we’ll take a look

[eladb]

This is resolved by #132