Discussion DSL Metrics

In https://github.com/cdsap/Talaiot/pull/167 @MyDogTom commented:

Customising which metrics are executed might be very confusing. For example, the following

talaiot {
  metrics {
    customMetrics(new MyMetric())
  }
}

will disable all metrics and use only MyMetric, because standard set of metrics is used only when there is no custom configuration. This might be not what people expect and not useful if I just want to add something on top of the standard configuration. Similar issue with the following configuration

talaiot {
  metrics {
    gitMetrics()
  }
}

From the DSL it’s not obvious what is actually happening.

It’s a very valid point. This issue is to discuss how we can offer a better approach for customizing metrics

[MyDogTom]

I propose the following DSL

talaiot {
    metrics {
        defaultMetrics = true // default is true
        gitMetrics = true // default is true
        environmentMetrics = true // default is true
        performanceMetrics = true // default is true
        gradleSwitchesMetrics = true // default is true
        customMetrics(
                new MyMetricA(),
                new MyMetricsB()
        )
    }
}

Like that built-in metrics are disabled only when it’s explicitly specified. I believe this should eliminate possibility for confusion while keeping the same flexibility level.

[cdsap]

yep, you’re right. I merged the PR.