RethinkDbPublisher, define timeout

When there are problems of connectivity with RethinkDbPublisher executions hangs with:

[RethinkDbPublisher]: ================
[RethinkDbPublisher]: RethinkDbPublisher
[RethinkDbPublisher]: publishBuildMetrics: true
[RethinkDbPublisher]: publishTaskMetrics: true
[RethinkDbPublisher]: ================
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination
[Talaiot]: Shutting down executor. Not yet. Still waiting for termination

Check timeout options in RethinkDbPublisher

[MyDogTom]

Sorry I’m afraid I don’t have enough knowledge to give a valuable input here. I’ll definitely take a closer look at the implementation to learn more. btw, time to time I also see

[Talaiot]: Shutting down executor. Not yet. Still waiting for termination

with InfluxDbPublisher, but only one occurrence per build.

[cdsap]

Hi @mokkun First, yep, the case using awaitTermination covers the case for the RethinkDbPublisher. It should be applied for the other publishers, but in case of InfluxDb it’s defined in the api of the influx client.

This bring to your second point about the “Network” implementation for the interface Publisher. I’m absolutely agree. Talaiot needs to implement a consistent network layer. Before entering in details I have some notes:

• Some publishers are using external dependencies to abstract the network logic,our new network implementation should cover cases when we have to use external apis, for example: – RethinkDbPublisher --> com.rethinkdb:rethinkdb-driver: – ElasticDbPublisher --> org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.0 – InfluxDb --> org.influxdb:influxdb-java:
• What do you think if for the threading model use Coroutines? First version of Talaiot was under 4.x Gradle Version. When we were targeting lower AGP versions, there were problems integrating Coroutines because the embedded Kotlin Compiler. Now is not a problem, should we move to coroutines in the new implementation?

Do you have more notes? @MyDogTom do you have any suggestions/notes for this rework of the Network Layer? Once we have the notes/suggestion collected we can create the issues/tasks and start working in this rework.

So, thank you very much for this proposals, I really appreciate it.