Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow governance approver to revoke an approval

See original GitHub issue

Challenge Description

Governance approvers play an important role in sanity checking that governance proposals are not malicious before they are put for referendum. In the unlikely event that governance approvers later learn of a show-stopping issue, this ticket calls for the ability for the governance approver to revoke their approval, effectively preventing an execution of a proposal.

Submission Requirements

  • Add a Governance#unapprove function which sets proposal.approved = false
  • Add a require during execute to check that the proposal is actually approved
  • Adding unit tests that check that a call to unapprove during approval, referendum and execution stage will effectively prevent the execution of the proposal (likely will want to check that proposal.approved == true in execute
  • Submit a PR and address PR review comments by core developers
  • Have the PR merged


  • Basic Solidity Knowledge
  • Minimal Familiarity with Celo Core Contracts

Time Expectation

  • 6 hours


Legacy Section

Expected Behavior

Governance revokeApproval implementation?

Current Behavior

Unclear if we want to allow revoking approvals

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

deepakhb2commented, Apr 7, 2021

@nambrot I can work on this issue and I understand requirement. Can I work on this issue?

github-actions[bot]commented, Jun 27, 2022

This issue is stale and will be closed in 30 days without activity

Read more comments on GitHub >

github_iconTop Results From Across the Web

Approve or deny access requests - entitlement management
Navigate to the Approvals tab in My Access. Go to the request you'd like to approve and click details. You can also click...
Read more >
20.4 Creating Request Approval Policies - Micro Focus
20.4.4 Configuring Automatic Approval at the Approval Step Level · In Identity Governance, select Policy > Access Request. · On the Approval Policies...
Read more >
Three-stage approval process for Azure AD access packages
8) To set the First approver, go to First Approver section and from the drop-down select the relevant option.
Read more >
Merge request approval settings - GitLab Docs
Require user password to approve · Enable password authentication for the web interface, as described in the sign-in restrictions documentation. · On the...
Read more >
Give edit access to the field "approver" for the - ServiceNow
Like the approvals in the change request table.. It should not happen for all sys_approval table.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found