Allow governance approver to revoke an approval

Challenge Description

Governance approvers play an important role in sanity checking that governance proposals are not malicious before they are put for referendum. In the unlikely event that governance approvers later learn of a show-stopping issue, this ticket calls for the ability for the governance approver to revoke their approval, effectively preventing an execution of a proposal.

Submission Requirements

• Add a Governance#unapprove function which sets proposal.approved = false
• Add a require during execute to check that the proposal is actually approved
• Adding unit tests that check that a call to unapprove during approval, referendum and execution stage will effectively prevent the execution of the proposal (likely will want to check that proposal.approved == true in execute
• Submit a PR and address PR review comments by core developers
• Have the PR merged

Prerequisites

• Basic Solidity Knowledge
• Minimal Familiarity with Celo Core Contracts

Time Expectation

• 6 hours

Resources

• Docs on Celo Governance
• Existing Governance approval unit tests

Legacy Section

Expected Behavior

Governance revokeApproval implementation?

Current Behavior

Unclear if we want to allow revoking approvals

[deepakhb2]

@nambrot I can work on this issue and I understand requirement. Can I work on this issue?

[github-actions[bot]]

This issue is stale and will be closed in 30 days without activity