[Bounty] FeeCurrencyWhitelist is not UsingRegistry storage variable
See original GitHub issueExpected Behavior
Because the Registry
address 0x0..ce10
(and for that matter the SortedOracles
address) are not expected to ever change, this contract can make the address static in its bytecode and avoid a complex Governance
situation.
In future it could save this and other core contracts a marginal amount of gas avoiding the relevant storage load operations.
This decision and migration from a storage registry address to a bytecode registry address should be well documented and understood.
Current Behavior
In this gitcoin bounty PR, it was discovered that FeeCurrencyWhitelist
is not already consuming UsingRegistry
for lack of use.
However, the ticket specifies that fee currencies should have oracle reports before they are whitelisted, meaning a lookup to the SortedOracles
contract through the registry. Introducing FeeCurrencyWhitelist is UsingRegistry
implies a storage level change which requires a new proxy deployment and initialization, and an atomic migration from the existing whitelist.
Issue Analytics
- State:
- Created 2 years ago
- Comments:18 (14 by maintainers)
Thank you @critesjosh I have submitted the work.
ok, I am chatting with gitcoin support right now. We’ll try to resolve this soon.