question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

cEUR support for Faucet

See original GitHub issue

Faucet: add ceur (?)

From scoping (issue #7100)

Here are the smaller sub-tasks that I think will need to be necessary for adding cEUR to the faucet (happy to move this discussion to slack as well, but wanted this documented on this ticket as well!):

celotool changes (use cases: large transfers of cUSD/CELO/cEUR on alfajores)

  • [coordinate with protocol economics] on how much cEUR to initially provide validator-0 @martinvol
  • modify the celotool script to allow for cEUR transfers and test this out (should be straightforward to add the additional arg)

web faucet changes (use cases: devs using web interface to request 5 CELO/10 cUSD/10? cEUR)

  • [web team] -> update the text on the faucet (very tiny change)
  • [coordinate with protocol economics] initialize web faucet address (0x22579ca45ee22e2e16ddf72d955d6cf4c767b0ef) with a large amount of cEUR @martinvol
  • redeploy faucetRequestProcessor firebase function (adding transfer command for cEUR should be mostly straightforward (steps enumerated below), testing may be slightly trickier. It should be possible to test this out with the firebase emulator, but double check this)
  1. modify buildHandleFaucet
  2. extend CeloAdapter; (possible option to modify transferDollars --> transferStable? May be overkill/not actually make future additions easier, already quite easy)
  3. test faucetRequestProcessor in firebase emulator if possible, or by deploying to staging? (second would be more complicated)
  4. deploy faucetRequestProcessor under a new name on firebase? --> can test, coordinate with web for testing this on staging once cEUR is on alfajores
  5. either redeploy previous function (same name) or coordinate with web to use newly deployed function once website mods are ok and faucet should start allowing for cEUR fauceting

alerting

  • set up a devX alert on GCP tracking cEUR (should take very little time, copy cUSD alert)

(- there’s an additional script: packages/faucet/scripts/transfer-funds.ts and it’s unclear where/what service is using this, as I believe the faucet runs using the firebase function described above.)

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
eelanagarajcommented, Apr 7, 2021

This took much longer than expected; getting testing set up and ready for the firebase changes ended up being much more involved than expected. (Using the firebase emulator wasn’t really possible; the email/login req for requests to work made it non trivial to trigger the function programmatically and not through the web UI or by manually entering data into the staging faucet). The e2e governance tests for the celotool continue to pose an issue even though these pass locally; likely known flakey test behavior but may still be tricky to merge this. Also took a bit longer as I took the time to make (slightly) more expansive changes to celotool fauceting in particular.

Updates/remaining TODOs here:

  • celotool updates ready to go, waiting on PR review (+ CI for e2e governance tests…passing locally but this may take a little while)
  • faucet firebase updates should also be ready to go, testing now works, but cannot deploy to staging until SDK version 1.1.1 is published (makes sense to wait for this as this offers more flexibility when it comes to stabletoken transfers in the future)
  • want to also take some time to update the faucet docs on notion about the architecture as hopefully this will save some debugging time in the future if anything comes up

Probably 1 more day of work on this with the above things (once unblocked),

0reactions
martinvolcommented, Apr 26, 2021

Amazing!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Fund Your Testnet Account - Celo.org
Enter the address of your Alfajores Testnet account to receive additional funds. Each request adds 5 CELO and 5 of each core stable...
Read more >
Delta Faucet Contact Us Center & Support Resources
View our Support Resources that can help solve your question or issue, and see ways to contact our support team for assistance.
Read more >
Coeur d'Alene - The Fixture Gallery
We provide a showroom and a one-on-one consultation with the customer to help you find the fixtures that best fit your style and...
Read more >
Contact Us - Pfister Faucets
Consumer Service Help Line. Telephone: 1-800- PFAUCET (1-800-732-8238) 7:00am to 4:00pm ...
Read more >
Chicago Faucets: Home
Resources. Build your own faucet with our Product Configurator. Or find support materials for the Chicago Faucets you already have. ... Support. Looking...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found