question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Confusion between `NumberPrompt` vs `Numeral`

See original GitHub issue

When trying to integrate Enquirer prompts for the first time It took some digging in your code to figure out how to get number prompts to work.

In your code you export a Numeral type.

https://github.com/cenk1cenk2/listr2/blob/1fbfaf27c2e3325855de73154689defabd679b0d/src/utils/prompt.interface.ts#L119

But in the enquirer docs they have a Markdown heading for a Numeral type (which is maybe where you got your naming from?) but the actual thing they export is a NumberPrompt:

https://github.com/enquirer/enquirer#numeral-prompt

I don’t know why they have this confusion either.

Is it possible to help clear up the confusion to make this more discoverable? Or make Number an alias of Numeral? Perhaps also document here which types Listr2 works with?

https://listr2.kilic.dev/general-usage/user-input

Thanks!

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
cenk1cenk2commented, Mar 31, 2021

I hope to not overwrite the types as soon as the merge request on the upstream merges. I only tried to convert the types that I was using at the time and added the rest mostly from the documentation, so it may be a little bit buggy. Sorry for that. You can easily see how that was not intended to be a long time solution from the extends clauses instead of a proper map.

I might take a look this weekend if i have some extra time, but can not promise since currently bit swamped. a pull request is welcome if you have any extra time.

0reactions
cenk1cenk2commented, Apr 4, 2021

🎉 This issue has been resolved in version 3.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Use Number vs numeral Correctly - Grammarist
Many people use the words number and numeral interchangeably, but these two words do not mean the same thing. We will examine the...
Read more >
What is the difference between 'number' and 'numeral'?
A numeral is a symbol or name that stands for a number. Examples: 3, 49 and twelve are all numerals. So the number...
Read more >
Confusion about Number.isNaN - Stack Overflow
isNaN() functions: one in the global scope, and one a property of Number . ... let theNumber = Number(prompt("Pick a number"));.
Read more >
what's the difference between number, digit and numeral?
NUMERALS : are the words or symbols that we use the represent our numbers. The list above is really a list of numerals....
Read more >
How does a switch/case function work with numbers?
I wanted to create a switch statement in which the cases are ranges of values. Example: var Number = prompt("Insert number between 0...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found