OpenCensus spans cap number of attributes at 32

Please answer these questions before submitting a bug report.

What version of OpenCensus are you using?

0.0.16

What version of Node are you using?

10.x

What did you do?

If possible, provide a recipe for reproducing the error. Generate a child span, and add more than 32 attributes

  let span     = tracer.startChildSpan({name, kind: 2});
  let i = 0;
  for ( ; i < 35; i++ ){ 
      span.addAttribute(`attr ${i}`, i);
 }

What did you expect to see?

All attributes show up in Jaeger

What did you see instead?

Only 32 attributes are preserved.

Additional context

There appears to be a maximum number of attributes for each span, set here: https://github.com/census-instrumentation/opencensus-node/blob/b2726345ccb3b97e87bf29bb18c50c7486b1e560/packages/opencensus-core/src/trace/sampler/sampler.ts#L131 Is there a reason why the maximum is set to 32?

[jdbennet2001]

Update: I’ve tested with no issue and am rolling the fix out. Thanks for all the help!

[mayurkale22]

@jdbennet2001 thanks for the confirmation, glad to help you 😃